Merge the Report._files/_chunks
#553
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges the previous `to_database` and `to_archive` methods into one, which serializes a Report to the `report_json` and `chunks` pairs, and can optionally return a `totals` dict as well.
Swatinem
force-pushed
the
swatinem/one-file
branch
from
38b2cc6 to
4974cef
Compare
Instead of maintaining two separate fields, this merges the previous `_files` which was a dict from filename to `totals`, and the `_chunks` which was either a fully parsed `ReportFile`, or just a shallow `list` of lines. Maintaining only a single structure for the list of files makes a ton of internals of the `Report` simpler. It also solves the problem of `file_totals` getting out of sync with the `ReportFile.totals`.
Swatinem
force-pushed
the
swatinem/one-file
branch
from
4974cef to
f6d9418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining two separate fields, this merges the previous
_fileswhich was a dict from filename tototals, and the_chunkswhich was either a fully parsedReportFile, or just a shallowlistof lines.Maintaining only a single structure for the list of files makes a ton of internals of the
Reportsimpler.It also solves the problem of
file_totalsgetting out of sync with theReportFile.totals.Builds on top of #552 and #554, and might still need a bit of more work.