-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch benchmarks back to instrumentation mode #555
Conversation
The walltime instrumentation is only usable on codspeed bare metal runners, which we don’t currently use. In the meantime, it would be nice to get *some* kind of result for the benchmark, even if it takes a long time.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 459 459
Lines 13130 13130
Branches 1510 1510
=======================================
Hits 11651 11651
Misses 1163 1163
Partials 316 316
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #555 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just not sure if we need the setup python action as well
@@ -28,11 +28,12 @@ jobs: | |||
- uses: actions/checkout@v4 | |||
|
|||
- uses: astral-sh/setup-uv@v5 | |||
- uses: actions/setup-python@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this since we're doing setup-uv already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.codspeed.io/benchmarks/python#usage-with-uv mentions that you should still use that instead of the uv-provided python.
The walltime instrumentation is only usable on codspeed bare metal runners, which we don’t currently use.
In the meantime, it would be nice to get some kind of result for the benchmark, even if it takes a long time.