Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch benchmarks back to instrumentation mode #555

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Mar 4, 2025

The walltime instrumentation is only usable on codspeed bare metal runners, which we don’t currently use.

In the meantime, it would be nice to get some kind of result for the benchmark, even if it takes a long time.

The walltime instrumentation is only usable on codspeed bare metal runners, which we don’t currently use.

In the meantime, it would be nice to get *some* kind of result for the benchmark, even if it takes a long time.
@Swatinem Swatinem requested a review from a team March 4, 2025 14:59
@Swatinem Swatinem self-assigned this Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (e9567e6) to head (0388cae).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   88.73%   88.73%           
=======================================
  Files         459      459           
  Lines       13130    13130           
  Branches     1510     1510           
=======================================
  Hits        11651    11651           
  Misses       1163     1163           
  Partials      316      316           
Flag Coverage Δ
shared-docker-uploader 88.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #555 will create unknown performance changes

Comparing swatinem/useful-bench (0388cae) with main (e9567e6)

Summary

🆕 17 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_parse_full[ReadOnlyReport] N/A 563.5 ms N/A
🆕 test_parse_full[Report] N/A 562.2 ms N/A
🆕 test_parse_full[Rust ReadOnlyReport] N/A 563.6 ms N/A
🆕 test_parse_shallow[ReadOnlyReport] N/A 7.4 ms N/A
🆕 test_parse_shallow[Report] N/A 7.2 ms N/A
🆕 test_parse_shallow[Rust ReadOnlyReport] N/A 7.5 ms N/A
🆕 test_process_totals[ReadOnlyReport] N/A 667.1 ms N/A
🆕 test_process_totals[Report] N/A 667 ms N/A
🆕 test_process_totals[Rust ReadOnlyReport] N/A 673.1 ms N/A
🆕 test_report_carryforward N/A 6.1 ms N/A
🆕 test_report_diff_calculation[FilteredReport] N/A 3.1 ms N/A
🆕 test_report_diff_calculation[Report] N/A 2 ms N/A
🆕 test_report_filtering[ReadOnlyReport] N/A 2.5 s N/A
🆕 test_report_filtering[Report] N/A 2.5 s N/A
🆕 test_report_filtering[Rust ReadOnlyReport] N/A 2.5 s N/A
🆕 test_report_merge N/A 3.1 s N/A
🆕 test_report_serialize N/A 4.8 ms N/A

@Swatinem Swatinem enabled auto-merge March 4, 2025 15:24
Copy link
Contributor

@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just not sure if we need the setup python action as well

@@ -28,11 +28,12 @@ jobs:
- uses: actions/checkout@v4

- uses: astral-sh/setup-uv@v5
- uses: actions/setup-python@v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this since we're doing setup-uv already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.codspeed.io/benchmarks/python#usage-with-uv mentions that you should still use that instead of the uv-provided python.

@Swatinem Swatinem added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 86fa843 Mar 5, 2025
12 checks passed
@Swatinem Swatinem deleted the swatinem/useful-bench branch March 5, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants