-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward get_flag_names
for the ReadOnlyReport
#556
Conversation
The `api_report_service.ReadOnlyReport` overrides the `flags` property, but it looks like the usage of `.flags` would be better served by `get_flag_names` instead. But that method previously did not exist on that `Report` class, so lets add it.
CodSpeed Performance ReportMerging #556 will create unknown performance changesComparing Summary
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 88.73% 88.72% -0.01%
==========================================
Files 459 459
Lines 13130 13132 +2
Branches 1510 1510
==========================================
+ Hits 11651 11652 +1
- Misses 1163 1164 +1
Partials 316 316
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
@@ -103,6 +103,9 @@ def flags(self): | |||
) | |||
return self._flags | |||
|
|||
def get_flag_names(self) -> list[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be caching the result of get_flag_names internally in the LazyRustReport
or even in the implementation of the inner report in resource.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make sense as a followup potentially. Though I guess this is already rather lightweight already, as it it just iterating through the sessions. Though its quite possible that reports have a shitton fo sessions because of perpetually carryforwarding old shit thats never being cleaned up or other kinds of reasons.
The
api_report_service.ReadOnlyReport
overrides theflags
property, but it looks like the usage of.flags
would be better served byget_flag_names
instead.But that method previously did not exist on that
Report
class, so lets add it.