Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support basic authentication when using a proxy #1067

Closed
drazisil-codecov opened this issue May 24, 2023 · 0 comments · Fixed by #1069
Closed

Feature Request: Support basic authentication when using a proxy #1067

drazisil-codecov opened this issue May 24, 2023 · 0 comments · Fixed by #1069
Assignees
Labels
enhancement New feature or request

Comments

@drazisil-codecov
Copy link
Contributor

Is your feature request related to a problem? Please describe.

According to the documentation, we should use the -U / --upstream args to enable proxy support. However, after trying this and examining the implementation details, it seems that this switch doesn't work for a proxy that requires basic authentication, such as --upstream=http://alice:pass@proxy.com/ .Could you please let me know if I'm mistaken and if there's a way to use codecov_uploader with a proxy that requires authentication?

also, as we see from the code, ProxyAgent from undici is used for the call, and it seems that "auth mode" is not supported for string argument passed by uploader.

This works:
"codecov_uploader -r ${repo} -C ${revision} -u ${server} / -f /coverage.xml -X network -F ${test_name}"

But this doesn't work:
"codecov_uploader --upstream http://user:pass@private_proxy.com/ -r ${repo} -C ${revision} -u ${server} -f coverage.xml -X network -F ${test_name}"

Describe the solution you'd like

A way to pass proxy credential to the uploader

Additional context

Opened on behalf of a customer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant