Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prevent symbolic link following #1223

Merged
merged 6 commits into from
Oct 19, 2023
Merged

feat: prevent symbolic link following #1223

merged 6 commits into from
Oct 19, 2023
+10 −0

Conversation

thomasrockhu-codecov
Copy link
Contributor

fixes #1126

@thomasrockhu-codecov thomasrockhu-codecov requested a review from a team as a code owner October 11, 2023 16:34
@thomasrockhu-codecov thomasrockhu-codecov force-pushed the feat-prevent-symbolic-link-following branch from e674a8a to b71c1bc Compare October 11, 2023 16:38
@thomasrockhu-codecov
feat: prevent symbolic link following

Verified

This commit was signed with the committer’s verified signature.
drazisil-codecov Joe Becher
GPG key ID: 42BBF73B175480C4
Verified
Learn about vigilant mode
72af56f
@thomasrockhu-codecov thomasrockhu-codecov force-pushed the feat-prevent-symbolic-link-following branch from b71c1bc to 72af56f Compare October 11, 2023 16:38
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #1223 (4a1e83d) into main (7a4b648) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1223   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          36       36           
  Lines        1357     1357           
  Branches      273      273           
=======================================
  Hits         1255     1255           
  Misses         70       70           
  Partials       32       32
Flag Coverage Δ
aarch64 92.48% <ø> (ø)
aarch64-without-git 92.48% <ø> (ø)
alpine 92.48% <ø> (ø)
alpine-proxy 92.48% <ø> (ø)
alpine-without-git 92.48% <ø> (ø)
linux 92.48% <ø> (ø)
linux-without-git 92.48% <ø> (ø)
macos 92.48% <ø> (ø)
macos-without-git 92.48% <ø> (ø)
windows 92.48% <ø> (ø)
windows-without-git ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/helpers/cli.ts 100.00% <ø> (ø)
src/helpers/files.ts 92.59% <ø> (ø)
src/index.ts 75.14% <ø> (ø)

NachoSoto
NachoSoto reviewed Oct 11, 2023
View reviewed changes
NachoSoto
NachoSoto reviewed Oct 11, 2023
View reviewed changes
@thomasrockhu-codecov @NachoSoto
Update src/helpers/cli.ts
27cb232 
Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>
@thomasrockhu-codecov thomasrockhu-codecov enabled auto-merge (squash) October 12, 2023 12:58
@NachoSoto NachoSoto mentioned this pull request Oct 19, 2023
Closed
@thomasrockhu-codecov thomasrockhu-codecov merged commit 61e0e4f into main Oct 19, 2023
@thomasrockhu-codecov thomasrockhu-codecov deleted the feat-prevent-symbolic-link-following branch October 19, 2023 18:14
thomasrockhu-codecov added a commit that referenced this pull request Oct 19, 2023
@thomasrockhu-codecov @NachoSoto
feat: prevent symbolic link following (#1223)
c79c267 
* feat: prevent symbolic link following

* Update src/helpers/cli.ts

Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>

* Update src/helpers/cli.ts

---------

Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NachoSoto NachoSoto

@drazisil-codecov drazisil-codecov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircleCI orb stuck at "Searching for coverage files..."
3 participants
@thomasrockhu-codecov @NachoSoto @drazisil-codecov