fix: remove unnecessary validation #467
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
- Coverage 92.91% 92.90% -0.01%
==========================================
Files 27 27
Lines 875 874 -1
Branches 172 172
==========================================
- Hits 813 812 -1
Misses 27 27
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mitchell-codecov
changed the title
|
This pull request introduces 1 alert when merging 66337ed into 2cf31fb - view on LGTM.com new alerts:
|
|
@mitchell-codecov status check :) |
|
This was marked "DO NOT MERGE" due to a minor UX concern. If a truly invalid URL is passed by the user, a fairly low-level error will be shown rather than one directly corresponding to the would-be invalid input. |
drazisil-codecov
approved these changes
Dec 29, 2021
mitchell-codecov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A future PR could
Fixes #452