Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress errors during glob for files #855

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Aug 17, 2022

If a directory or file exists, but Codecov does not have read access, glob will return a

There was an error running the uploader: EACCES: permission denied, scandir <directory>

error. This should be avoided, and uploading should continue as expected

Related: https://community.codecov.com/t/cant-make-ignore-option-work-for-directory-with-strict-permissions/3814

Verified

This commit was signed with the committer’s verified signature.
drazisil-codecov Joe Becher
@thomasrockhu-codecov thomasrockhu-codecov requested a review from a team as a code owner August 17, 2022 22:22
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #855 (71b7300) into main (74e5623) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          34       34           
  Lines        1181     1181           
  Branches      244      244           
=======================================
  Hits         1085     1085           
  Misses         64       64           
  Partials       32       32           
Flag Coverage Δ
alpine 91.87% <ø> (ø)
alpine-proxy 91.87% <ø> (ø)
alpine-without-git 91.87% <ø> (ø)
linux 91.87% <ø> (ø)
linux-without-git 91.87% <ø> (ø)
macos 91.87% <ø> (ø)
macos-without-git 91.87% <ø> (ø)
windows 91.87% <ø> (ø)
windows-without-git 91.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/files.ts 92.30% <ø> (ø)

@mitchell-codecov mitchell-codecov merged commit f8d7a3a into main Aug 18, 2022
@mitchell-codecov mitchell-codecov deleted the fix-supress-file-access-errors branch August 18, 2022 12:26
@mitchell-codecov mitchell-codecov linked an issue Aug 22, 2022 that may be closed by this pull request
thomasrockhu-codecov added a commit that referenced this pull request Aug 24, 2022
* chore(deps): update github/codeql-action digest to 2ca79b6 (#789)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency undici to v5.8.1 (#843)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency undici to v5.8.2 (#844)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update alpine docker tag to v3.16.2 (#845)

chore(deps): update dependency alpine to v3.16.2

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Skip empty paths when more than one is passed (#848)

* Skip empty paths when more than one is passed

* Use `||` instead of `??`

* chore(deps): update google/cloud-sdk docker tag to v397 (#846)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: suppress errors during glob for files (#855)

fix: supress errors during glob for files

Co-authored-by: Tom Hu <tomhu1096+gpg@gmail.com>

* fix(deps): update dependency undici to v5.9.1 (#854)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mitchell Borrego <mitchell@codecov.io>

* chore(deps): update google/cloud-sdk docker tag to v398 (#853)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update node.js to v16.17.0 (#852)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mitchell Borrego <mitchell@codecov.io>

* feat: accept comma-separated files in args (#861)

Co-authored-by: Tom Hu <tomhu1096+gpg@gmail.com>

* fix(deps): update dependency undici to v5.10.0 (#862)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): 0.2.6 (#863)

Co-authored-by: Tom Hu <tomhu1096+gpg@gmail.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mitchell Borrego <mitchell@codecov.io>
Co-authored-by: Tom Hu <tomhu1096+gpg@gmail.com>
thomasrockhu-codecov added a commit that referenced this pull request Aug 24, 2022
* chore(deps): update github/codeql-action digest to 2ca79b6 (#789)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency undici to v5.8.1 (#843)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency undici to v5.8.2 (#844)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update alpine docker tag to v3.16.2 (#845)

chore(deps): update dependency alpine to v3.16.2

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Skip empty paths when more than one is passed (#848)

* Skip empty paths when more than one is passed

* Use `||` instead of `??`

* chore(deps): update google/cloud-sdk docker tag to v397 (#846)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: suppress errors during glob for files (#855)

fix: supress errors during glob for files

Co-authored-by: Tom Hu <tomhu1096+gpg@gmail.com>

* fix(deps): update dependency undici to v5.9.1 (#854)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mitchell Borrego <mitchell@codecov.io>

* chore(deps): update google/cloud-sdk docker tag to v398 (#853)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update node.js to v16.17.0 (#852)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mitchell Borrego <mitchell@codecov.io>

* feat: accept comma-separated files in args (#861)

Co-authored-by: Tom Hu <tomhu1096+gpg@gmail.com>

* fix(deps): update dependency undici to v5.10.0 (#862)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(release): 0.2.6 (#863)

Co-authored-by: Tom Hu <tomhu1096+gpg@gmail.com>

* Release 0.2.6 (#866)

* Revert "chore(release): 0.2.6 (#863)"

This reverts commit 79543f0.

* chore(release): 0.2.6

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mitchell Borrego <mitchell@codecov.io>
Co-authored-by: Tom Hu <tomhu1096+gpg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uploader crashes when it encounters a file io error
4 participants