Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to NOT search for coverage files #530

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Dec 2, 2021

Use the -X search from the bash uploader

Closes #514

@Flamefire Flamefire requested a review from a team as a code owner December 2, 2021 16:00
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #530 (d32d2a6) into master (7d4690e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          28       28           
  Lines         976      977    +1     
  Branches      193      194    +1     
=======================================
+ Hits          915      916    +1     
  Misses         27       27           
  Partials       34       34           
Flag Coverage Δ
alpine 93.75% <100.00%> (+<0.01%) ⬆️
alpine-proxy 93.75% <100.00%> (+<0.01%) ⬆️
alpine-without-git 93.75% <100.00%> (+<0.01%) ⬆️
linux 93.75% <100.00%> (+<0.01%) ⬆️
linux-without-git 93.75% <100.00%> (+<0.01%) ⬆️
macos 93.75% <100.00%> (+<0.01%) ⬆️
macos-without-git 93.75% <100.00%> (+<0.01%) ⬆️
windows 93.75% <100.00%> (+<0.01%) ⬆️
windows-without-git 93.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/cli.ts 100.00% <ø> (ø)
src/index.ts 79.04% <100.00%> (+0.20%) ⬆️

Verified

This commit was signed with the committer’s verified signature.
drazisil-codecov Joe Becher
Use the `-X search` from the bash uploader
@Flamefire Flamefire force-pushed the Exclude-search-option branch from f0fd00c to 6e9a532 Compare December 2, 2021 16:07
@Flamefire Flamefire force-pushed the Exclude-search-option branch from 3006cf7 to d32d2a6 Compare December 2, 2021 16:21
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@drazisil-codecov drazisil-codecov merged commit c95e6f1 into codecov:master Dec 16, 2021
@Flamefire Flamefire deleted the Exclude-search-option branch December 16, 2021 14:05
@drazisil-codecov drazisil-codecov mentioned this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The uploader should not search for coverage files when -f is used.
2 participants