Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob path support for Windows drive letters #544

Closed
drazisil-codecov opened this issue Dec 16, 2021 · 3 comments · Fixed by #1099
Closed

Glob path support for Windows drive letters #544

drazisil-codecov opened this issue Dec 16, 2021 · 3 comments · Fixed by #1099
Assignees
Labels
bug Something isn't working

Comments

@drazisil-codecov
Copy link
Contributor

[2021-10-27T15:59:01.743Z] ['verbose'] Possible coverage patterns, after globbing **/C:\Users\circleci\project\coverage\cobertura-coverage.xml

Looks like we need to strip the glob prefix if we detect we have a drive letter.

Originally posted by @drazisil-codecov in #464 (comment)

@drazisil-codecov
Copy link
Contributor Author

@mitchell-codecov do you remember if we fixed this?

@drazisil-codecov drazisil-codecov added the bug Something isn't working label Jan 5, 2022
@mitchell-codecov
Copy link
Contributor

Not to my knowledge. Something we did learn was that the library we use for globbing has Windows-oriented capabilities which may be of interest.

@trent-codecov
Copy link

@joseph-sentry Please take a look here if we still need to do this and work with @dana-yaish for a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants