-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CODE-1052] Invalid string length while appending coverage files for upload #553
Comments
Think we'll need to refactor away from using |
Will that fix this? The issue, as I understand it, is here Line 214 in 8f317a4
|
Yea - on occasion there must be files large enough that we hit the max allowed in node.js process since we read the whole file into memory via |
Closed by #746 |
Describe the bug
On Linux:
['error'] There was an error running the uploader: Invalid string length
On MacOS:
: Error: Cannot create a string longer than 0x1fffffe8 characters
This occurs when appending large XML coverage reports during the
Processing <filename>
step.To Reproduce
Steps to reproduce the behavior:
./codecov -f ~/Downloads/enwik9
Expected behavior
The uploader is unable to handle large files concatenated together. This appears to be a V8 limit, see GitHub issue in the additional context section.
Additional context
nodejs/node#35973 (comment)
The text was updated successfully, but these errors were encountered: