Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CODE-1717] Version 0.1.20 treats -f '' as -f '**/ and attempts to include all files #677

Closed
drazisil-codecov opened this issue Mar 23, 2022 · 0 comments · Fixed by #808 or #848
Closed

[CODE-1717] Version 0.1.20 treats -f '' as -f '**/ and attempts to include all files #677

drazisil-codecov opened this issue Mar 23, 2022 · 0 comments · Fixed by #808 or #848
Assignees
@mitchell-codecov
Labels
bug Something isn't working selected for development Used for issues that the codecov team is/will be actively working on

Comments

@drazisil-codecov
Copy link
Contributor

Describe the bug
Version 0.1.20 treats -f '' as -f '**/ and attempts to include all files

To Reproduce
Steps to reproduce the behavior:

  1. Pass -f '' to the uploader
  2. Observe file list of coverage paths to clean

Expected behavior

Return a warning that -f was passed an empty string and delete the arg, behaving as if it was not passed.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
This is essentially painful on large repositories.
@drazisil-codecov drazisil-codecov added the bug Something isn't working label Mar 23, 2022
@mitchell-codecov mitchell-codecov mentioned this issue Jun 16, 2022
Closed
@drazisil-codecov drazisil-codecov added the selected for development Used for issues that the codecov team is/will be actively working on label Jun 17, 2022
@drazisil-codecov drazisil-codecov changed the title Version 0.1.20 treats -f '' as -f '**/ and attempts to include all files [CODE-1717] Version 0.1.20 treats -f '' as -f '**/ and attempts to include all files Jun 17, 2022
This was linked to pull requests Aug 15, 2022
Handle strings like before #808
Merged
Skip empty paths when more than one is passed #848
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchell-codecov mitchell-codecov

Labels
bug Something isn't working selected for development Used for issues that the codecov team is/will be actively working on
Projects
None yet
Milestone
No milestone
2 participants
@drazisil-codecov @mitchell-codecov