Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move checkSlug fn to validate #990

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Conversation

thomasrockhu-codecov
Copy link
Contributor

fixes #830

Verified

This commit was signed with the committer’s verified signature.
drazisil-codecov Joe Becher
@thomasrockhu-codecov thomasrockhu-codecov requested a review from a team as a code owner March 24, 2023 23:10
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #990 (7d228ee) into main (5b26dbc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   92.44%   92.43%   -0.01%     
==========================================
  Files          36       35       -1     
  Lines        1310     1309       -1     
  Branches      265      265              
==========================================
- Hits         1211     1210       -1     
  Misses         67       67              
  Partials       32       32              
Flag Coverage Δ
alpine 92.36% <100.00%> (-0.01%) ⬇️
alpine-proxy 92.36% <100.00%> (-0.01%) ⬇️
alpine-without-git 92.36% <100.00%> (-0.01%) ⬇️
linux 92.36% <100.00%> (-0.01%) ⬇️
linux-without-git 92.36% <100.00%> (-0.01%) ⬇️
macos 92.36% <100.00%> (-0.01%) ⬇️
macos-without-git 92.36% <100.00%> (-0.01%) ⬇️
windows 91.74% <100.00%> (-0.01%) ⬇️
windows-without-git 91.74% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/validate.ts 100.00% <100.00%> (ø)
src/index.ts 75.73% <100.00%> (-0.15%) ⬇️

@thomasrockhu-codecov thomasrockhu-codecov merged commit c468bfd into main Mar 27, 2023
@thomasrockhu-codecov thomasrockhu-codecov deleted the migrate-checkslug-fn branch March 27, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A future PR should move this function to [validate.ts].
2 participants