Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing link to feedback issue from TA comments #1036

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

removing link to feedback issue from TA comments #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/test_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def generate_failure_info(
def generate_view_test_analytics_line(commit: Commit) -> str:
repo = commit.repository
test_analytics_url = get_test_analytics_url(repo, commit)
return f"\nTo view more test analytics, go to the [Test Analytics Dashboard]({test_analytics_url})\n:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/304)"
return f"\nTo view more test analytics, go to the [Test Analytics Dashboard]({test_analytics_url})\n"


def messagify_failure(
Expand Down
6 changes: 2 additions & 4 deletions services/tests/test_test_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,7 @@ def test_build_message():

</details>

To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/thing%2Fthing)
:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/304)"""
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/thing%2Fthing)"""
)


Expand Down Expand Up @@ -197,8 +196,7 @@ def test_build_message_with_flake():

</details>

To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/{commit.branch})
:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/304)"""
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/{services_short_dict.get(commit.repository.service)}/{commit.repository.owner.username}/{commit.repository.name}/tests/{commit.branch})"""
)


Expand Down
3 changes: 1 addition & 2 deletions tasks/tests/unit/test_ta_finisher_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,5 @@ def test_test_analytics(

</details>

To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/{short_form_service_name}/{upload.report.commit.repository.owner.username}/{upload.report.commit.repository.name}/tests/{upload.report.commit.branch})
:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/304)""",
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/{short_form_service_name}/{upload.report.commit.repository.owner.username}/{upload.report.commit.repository.name}/tests/{upload.report.commit.branch})""",
)
12 changes: 4 additions & 8 deletions tasks/tests/unit/test_test_results_finisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,8 +453,7 @@ def test_upload_finisher_task_call(

</details>

To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)
:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/304)""",
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)""",
)

@pytest.mark.integration
Expand Down Expand Up @@ -766,8 +765,7 @@ def test_upload_finisher_task_call_existing_comment(

</details>

To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)
:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/304)""",
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)""",
)

assert expected_result == result
Expand Down Expand Up @@ -927,8 +925,7 @@ def test_upload_finisher_task_call_with_flaky(

</details>

To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)
:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/304)""",
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)""",
)

@pytest.mark.integration
Expand Down Expand Up @@ -1100,8 +1097,7 @@ def test_upload_finisher_task_call_computed_name(

</details>

To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)
:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/304)""",
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)""",
)

@pytest.mark.integration
Expand Down
Loading