Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove TA BQ code #1083

Merged
merged 1 commit into from
Feb 28, 2025
Merged

chore: remove TA BQ code #1083

merged 1 commit into from
Feb 28, 2025

Conversation

joseph-sentry
Copy link
Contributor

we won't be needing this in the future anymore

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.63%. Comparing base (899d4dd) to head (7ad4b5f).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
+ Coverage   97.25%   97.63%   +0.38%     
==========================================
  Files         454      448       -6     
  Lines       37447    37107     -340     
==========================================
- Hits        36418    36230     -188     
+ Misses       1029      877     -152     
Flag Coverage Δ
integration 43.02% <100.00%> (-0.05%) ⬇️
unit 90.16% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
Contributor

@nora-codecov nora-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big cleanup 💪

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I feel a bit out of the loop here. we discussed (not) using bigquery for a while, but I somehow missed the decision to go ahead and remove this.

@joseph-sentry
Copy link
Contributor Author

TBH, I feel a bit out of the loop here. we discussed (not) using bigquery for a while, but I somehow missed the decision to go ahead and remove this.

oh sorry about that, there was no formal decision, i just thought since i was adding the Timescale code it would be cleaner to remove the BQ code for now. (It would also make my work with adding the timescale experimentation stuff easier since there's less changes to keep track of).

@joseph-sentry joseph-sentry added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 8ca3427 Feb 28, 2025
28 of 29 checks passed
@joseph-sentry joseph-sentry deleted the joseph/remove-bq branch February 28, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants