-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove TA BQ code #1083
chore: remove TA BQ code #1083
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
+ Coverage 97.25% 97.63% +0.38%
==========================================
Files 454 448 -6
Lines 37447 37107 -340
==========================================
- Hits 36418 36230 -188
+ Misses 1029 877 -152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
big cleanup 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I feel a bit out of the loop here. we discussed (not) using bigquery for a while, but I somehow missed the decision to go ahead and remove this.
oh sorry about that, there was no formal decision, i just thought since i was adding the Timescale code it would be cleaner to remove the BQ code for now. (It would also make my work with adding the timescale experimentation stuff easier since there's less changes to keep track of). |
7552eec
to
ea719a7
Compare
ea719a7
to
7ad4b5f
Compare
we won't be needing this in the future anymore