-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move sync_repos_languages task to get_repo_provider_service wrapper #1109
Conversation
8e209ab
to
5e697f6
Compare
5e697f6
to
6ef1e94
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1109 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 454 454
Lines 37394 37394
=======================================
+ Hits 36367 36368 +1
+ Misses 1027 1026 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though at least cleaning up the duplicated logs would be nice
owner_id=repository.ownerid or "", | ||
repository_id=repository.repoid, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both of these are now covered by the LogContext
, so I would not duplicate them here.
installation_name_to_use = get_installation_name_for_owner_for_task( | ||
self.name, repository.owner | ||
) | ||
repository_service = get_repo_provider_service( | ||
repository, installation_name_to_use=installation_name_to_use | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remember that I may have created "yet another" wrapper that takes care of this installation_name_to_use
, and introduces a cache for these things.
Or I tried and failed because these things are not cache-able.
depends on: #1107
part of: codecov/engineering-team#3389
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.