Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shared again, removing change_sessionid #1110

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Update shared again, removing change_sessionid #1110

merged 1 commit into from
Feb 28, 2025

Conversation

Swatinem
Copy link
Contributor

This function has been moved to shared, so can now be removed from worker.

@Swatinem Swatinem requested a review from a team February 26, 2025 10:28
@Swatinem Swatinem self-assigned this Feb 26, 2025
@github-actions GitHub Actions
Copy link

This PR includes changes to shared. Please review them here: codecov/shared@47fa7fd...f0be4d9

@Swatinem Swatinem force-pushed the swatinem/update-shared branch from b0a22a5 to fa901c9 Compare February 26, 2025 11:47
@Swatinem
Copy link
Contributor Author

This is currently blocked on codecov/shared#539 and codecov/shared#540

@Swatinem Swatinem force-pushed the swatinem/update-shared branch 2 times, most recently from 233d18f to d422eef Compare February 27, 2025 08:17
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (e0b5c7f) to head (42c6213).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1110   +/-   ##
=======================================
  Coverage   97.25%   97.26%           
=======================================
  Files         454      454           
  Lines       37447    37425   -22     
=======================================
- Hits        36418    36400   -18     
+ Misses       1029     1025    -4
Flag Coverage Δ
integration 43.04% <100.00%> (-0.03%) ⬇️
unit 89.85% <95.23%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

giovanni-guidini
giovanni-guidini approved these changes Feb 27, 2025
View reviewed changes
pyproject.toml
shared = { git = "https://github.com/codecov/shared", rev = "fd58134d9f15bce28917f68bda9e740dd9fe32ff" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice to see the uv stuff. way better

@Swatinem
Update shared again, removing change_sessionid
42c6213 
This function has been moved to `shared`, so can now be removed from `worker`.
@Swatinem Swatinem force-pushed the swatinem/update-shared branch from d422eef to 42c6213 Compare February 28, 2025 08:35
@Swatinem Swatinem added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit f281cb2 Feb 28, 2025
28 of 29 checks passed
@Swatinem Swatinem deleted the swatinem/update-shared branch February 28, 2025 09:02
@Swatinem Swatinem mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovanni-guidini giovanni-guidini

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @giovanni-guidini