-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TA should read comment config value #1111
Conversation
prevously it wasn't checking these settings, but it lead to users getting the TA / upgrade comment only, so we should check it
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: tasks/ta_finisher.py
📄 File: tasks/test_results_finisher.py (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
- Coverage 97.25% 97.24% -0.02%
==========================================
Files 454 454
Lines 37335 37343 +8
==========================================
+ Hits 36310 36313 +3
- Misses 1025 1030 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
This reminds me that we should clean up the distinction between Lets have another chat about what your plans for this were, and lets work towards removing the duplication. |
Customer reached out about this and wanted to confirm the fix is it released? They noticed they no longer have a comment of either the patch report or the warning |
prevously it wasn't checking these settings, but it lead to users getting the TA / upgrade comment only, so we should check it