Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TA should read comment config value #1111

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

joseph-sentry
Copy link
Contributor

prevously it wasn't checking these settings, but it lead to users getting the TA / upgrade comment only, so we should check it

prevously it wasn't checking these settings, but it lead to users
getting the TA / upgrade comment only, so we should check it
@joseph-sentry joseph-sentry requested a review from a team February 26, 2025 15:58
Copy link

sentry-io bot commented Feb 26, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/ta_finisher.py

Function Unhandled Issue
process_impl_within_lock KeyError: 2385421152 app.tasks.test_results.TAFin...
Event Count: 1
📄 File: tasks/test_results_finisher.py (Click to Expand)
Function Unhandled Issue
process_impl_within_lock AttributeError: 'NoneType' object has no attribute 'pullid' app.tasks.test_results.TestResultsF...
Event Count: 113
---

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.24%. Comparing base (74b3287) to head (5ad785c).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/ta_finisher.py 33.33% 4 Missing ⚠️
tasks/test_results_finisher.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
- Coverage   97.25%   97.24%   -0.02%     
==========================================
  Files         454      454              
  Lines       37335    37343       +8     
==========================================
+ Hits        36310    36313       +3     
- Misses       1025     1030       +5     
Flag Coverage Δ
integration 43.11% <40.00%> (-0.01%) ⬇️
unit 89.77% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/ta_finisher.py 33.33% 4 Missing ⚠️
tasks/test_results_finisher.py 62.50% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Swatinem
Copy link
Contributor

This reminds me that we should clean up the distinction between ta_finisher and test_results_finisher.

Lets have another chat about what your plans for this were, and lets work towards removing the duplication.

@joseph-sentry joseph-sentry added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 9449bce Feb 27, 2025
21 of 29 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-ta-comment branch February 27, 2025 18:55
@jessecodecov
Copy link

@joseph-sentry

Customer reached out about this and wanted to confirm the fix is it released?

They noticed they no longer have a comment of either the patch report or the warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants