Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin vcrpy #1115

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Unpin vcrpy #1115

merged 1 commit into from
Mar 3, 2025

Conversation

Swatinem
Copy link
Contributor

The proposed PR to convert api to a pyproject.toml defines a different version for its vcrpy dependency. Lets unpin the dependency here, so a workspace pulling in both will work.

The proposed PR to convert `api` to a `pyproject.toml` defines a different version for its `vcrpy` dependency.
Lets unpin the dependency here, so a workspace pulling in both will work.
@Swatinem Swatinem requested a review from a team February 28, 2025 13:07
@Swatinem Swatinem self-assigned this Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (f281cb2) to head (c405c7e).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1115   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         454      454           
  Lines       37425    37425           
=======================================
  Hits        36400    36400           
  Misses       1025     1025           
Flag Coverage Δ
integration 43.04% <ø> (ø)
unit 89.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@Swatinem Swatinem added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 4ab11db Mar 3, 2025
29 checks passed
@Swatinem Swatinem deleted the swatinem/unpin-vcrpy branch March 3, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants