chore: remove previous code #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: since the NEW_TA_TASKS feature flag is not enabled for any repos we're safe to remove the ta_* tasks since they aren't being queued up anywhere in the old version of the code anyways this commit removes the TA finisher tasks and replaces the call to queue those up in the upload task with a call to queue up a separate chain of processor tasks with the new_impl kwarg set to True. We can pass this extra kwarg because the processor task has **kwargs which makes it so even old versions of the code are compatible with this version of the upload task until we have the new implementation of the processor task deployed we should not enable NEW_TA_TASKS since it will possibly cause duplicate TA uploads to be processed
joseph-sentry
force-pushed
the
joseph/update-new-ta
branch
from
b772e74 to
fa09518
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1116 +/- ##
==========================================
+ Coverage 97.64% 97.73% +0.08%
==========================================
Files 448 443 -5
Lines 37085 36565 -520
==========================================
- Hits 36212 35737 -475
+ Misses 873 828 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nora-codecov
approved these changes
Mar 1, 2025
Swatinem
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: since the NEW_TA_TASKS feature flag is not enabled for any repos we're safe to remove the ta_* tasks since they aren't being queued up anywhere in the old version of the code anyways
this commit removes the TA finisher tasks and replaces the call to queue those up in the upload task with a call to queue up a separate chain of processor tasks with the new_impl kwarg set to True. We can pass this extra kwarg because the processor task has **kwargs which makes it so even old versions of the code are compatible with this version of the upload task
until we have the new implementation of the processor task deployed we should not enable NEW_TA_TASKS since it will possibly cause duplicate TA uploads to be processed