Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove previous code #1116

Merged
merged 1 commit into from
Mar 3, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: remove previous code
note: since the NEW_TA_TASKS feature flag is not enabled for any repos
we're safe to remove the ta_* tasks since they aren't being queued up
anywhere in the old version of the code anyways

this commit removes the TA finisher tasks and replaces the call to
queue those up in the upload task with a call to queue up a separate
chain of processor tasks with the new_impl kwarg set to True. We can
pass this extra kwarg because the processor task has **kwargs which
makes it so even old versions of the code are compatible with this
version of the upload task

until we have the new implementation of the processor task deployed
we should not enable NEW_TA_TASKS since it will possibly cause
duplicate TA uploads to be processed
  • Loading branch information
joseph-sentry committed Feb 28, 2025
commit fa09518dcf145fb53c95cbadc93598fd69fa6841
21 changes: 0 additions & 21 deletions ta_storage/utils.py

This file was deleted.

2 changes: 0 additions & 2 deletions tasks/__init__.py
Original file line number Diff line number Diff line change
@@ -49,8 +49,6 @@
from tasks.sync_repo_languages_gql import sync_repo_languages_gql_task
from tasks.sync_repos import sync_repos_task
from tasks.sync_teams import sync_teams_task
from tasks.ta_finisher import ta_finisher_task
from tasks.ta_processor import ta_processor_task
from tasks.test_results_finisher import test_results_finisher_task
from tasks.test_results_processor import test_results_processor_task
from tasks.timeseries_backfill import (
Loading
Oops, something went wrong.
Loading
Oops, something went wrong.