Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass in uv-lock for self-hosted cache image stuff #1123

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

ajay-sentry
Copy link
Contributor

Unblocks self-hosted release because we weren't passing in the uv.lock param to use that cached image, so it was referencing the requirements.txt image when that one is no longer being built

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (b4867ea) to head (30544f3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         443      443           
  Lines       36565    36565           
=======================================
  Hits        35754    35754           
  Misses        811      811           
Flag Coverage Δ
integration 42.66% <ø> (ø)
unit 90.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov added this pull request to the merge queue Mar 4, 2025
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Merged via the queue into main with commit 261478c Mar 4, 2025
29 checks passed
@nora-codecov nora-codecov deleted the Ajay/uv-lock-stuff branch March 4, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants