Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript 3.7 support #10

Closed
nwtgck opened this issue Nov 6, 2019 · 1 comment
Closed

Add TypeScript 3.7 support #10

nwtgck opened this issue Nov 6, 2019 · 1 comment

Comments

@nwtgck
Copy link

nwtgck commented Nov 6, 2019

Hi developers,

Thank you very much for the wonderful project! Currently, CodeFactor doesn't seem to support TypeScript 3.7 features such as Optional chaining and Nullish coalescing.

Here are CodeFactor's issues related to the features.
https://www.codefactor.io/repository/github/nwtgck/piping-server/commit/5617fe76ebec4ac9337ca8690156ce7bfa359fa2

Here is a PR auto-generated by CodeFactor.
https://github.com/nwtgck/piping-server/pull/221/files
The code change is not proper syntax in TypeScript 3.7.

Example: Optional chaining

image

Example: Nullish coalescing

image

@cordis-dev
Copy link
Contributor

@nwtgck thanks for reporting, TypeScript is now updated to 3.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants