Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor, env vars, and update packages #598

Merged
merged 21 commits into from
Jul 29, 2021
Merged

Refactor, env vars, and update packages #598

merged 21 commits into from
Jul 29, 2021
+1,356 −1,901

Conversation

xavier506
Copy link
Member

@xavier506 xavier506 commented Jul 16, 2021 •
edited
Loading

GH Issue

resolve #587
resolve #613
resolve #618
resolve #604

Chart.js breaking changes specification here

Eslintrc bug fix here

@xavier506 xavier506 added the WIP Work In Progress label Jul 16, 2021
@xavier506 xavier506 removed the WIP Work In Progress label Jul 17, 2021
@xavier506 xavier506 added the WIP Work In Progress label Jul 21, 2021
@leisterfrancisco
Copy link
Member

@tetogomez @adriexnet @AngeloCG97

Localhost:
image

Production:
image

After updating chart.js and react-chartjs-2 It came with breaking changes that after fixing them produced some UI differences any suggestion?

@leisterfrancisco leisterfrancisco self-assigned this Jul 22, 2021
@leisterfrancisco leisterfrancisco removed their request for review July 22, 2021 12:49
leisterfrancisco and others added 3 commits July 23, 2021 14:29
@leisterfrancisco
Merge branch 'staging' of https://github.com/eoscostarica/eos-rate in…
72fff06 
…to fix/update-packages
@leisterfrancisco
fix(chart): improve design
231a663
@xavier506
standarize env var prefix names (#619)
143bb46 
* fix(hapi): standarize env var prefix names

* fix(webapp): standarize env var prefix names
@xavier506 xavier506 changed the title Update node modules Refactor env vars and update packages Jul 27, 2021
leisterfrancisco
leisterfrancisco reviewed Jul 27, 2021
View reviewed changes
leisterfrancisco
leisterfrancisco reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@leisterfrancisco leisterfrancisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavier506 thanks very much about file restructuring, looks so nice now. 💯

@xavier506 xavier506 changed the title Refactor env vars and update packages Refactor, env vars, and update packages Jul 27, 2021
leisterfrancisco
leisterfrancisco reviewed Jul 28, 2021
View reviewed changes
leisterfrancisco
leisterfrancisco reviewed Jul 28, 2021
View reviewed changes
.env.example Outdated
WEBAPP_GRAPHQL_HTTP_URL=http://localhost:8080/v1/graphql
WEBAPP_API_URL=https://jungle.eosio.cr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavier506 should I remove it, right? is not been used except by webapp/Dockerfile

@leisterfrancisco leisterfrancisco requested review from leisterfrancisco and removed request for leisterfrancisco July 28, 2021 15:16
@leisterfrancisco leisterfrancisco removed the WIP Work In Progress label Jul 28, 2021
@xavier506 xavier506 merged commit e5ab380 into staging Jul 29, 2021
@xavier506 xavier506 deleted the fix/update-packages branch August 2, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriexnet adriexnet

@tetogomez tetogomez

@AngeloCG97 AngeloCG97

@leisterfrancisco leisterfrancisco

Assignees

@leisterfrancisco leisterfrancisco

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@xavier506 @leisterfrancisco @AngeloCG97