Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are ESLint custom configs supported? #24

Closed
tomcastro opened this issue Nov 23, 2020 · 1 comment
Closed

Are ESLint custom configs supported? #24

tomcastro opened this issue Nov 23, 2020 · 1 comment

Comments

@tomcastro
Copy link

Hi everyone!

We are trying out Codefactor for our organization and it works great so far.

Our only problem comes from having a custom ESLint configurations:

image

Our .eslintrc.json file:

{
  "parser": "@typescript-eslint/parser",
  "extends": [
    "rokket-labs",
    "rokket-labs/react",
    "eslint:recommended",
    "plugin:@typescript-eslint/recommended",
    "prettier/@typescript-eslint"
  ],
  "settings": {
    "react": {
      "version": "detect"
    }
  },
  "env": {
    "browser": true,
    "node": true,
    "es6": true
  },
  "plugins": ["@typescript-eslint", "react"],
  "parserOptions": {
    "ecmaFeatures": {
      "jsx": true
    },
    "ecmaVersion": 2018,
    "sourceType": "module"
  },
  "rules": {
    "react/prop-types": "off",
    "@typescript-eslint/explicit-function-return-type": "off",
    "no-use-before-define": "off",
    "@typescript-eslint/no-use-before-define": ["error"]
  },
  "overrides": [
    {
      "files": ["*.js"],
      "rules": {
        "@typescript-eslint/no-var-requires": "off"
      }
    }
  ]
}

The error reads out not supported dependencies: rokket-labs. Here's our custom config.

Is this kind of configuration supported? I'm pretty sure we're not using any plugins outside of the ones specified here.

@cordis-dev
Copy link
Contributor

@tomcastro thanks for reaching out. Yes, such configuration are supported. You should now see proper results for your repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants