Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated cpplint.py #54

Closed
Jhuighuy opened this issue Dec 13, 2022 · 1 comment
Closed

Outdated cpplint.py #54

Jhuighuy opened this issue Dec 13, 2022 · 1 comment

Comments

@Jhuighuy
Copy link

Jhuighuy commented Dec 13, 2022

Hi!

Looks like the cpplint.py is outdated and cannot handle the C++17 (and more recent) code.

For example, consider this issue:

https://www.codefactor.io/repository/github/jhuighuy/stormruler/source/main/source/Storm/Bittern/MatrixMath.hpp#L53

Cpplint complains that <tuple> header is not included, although it is clearly included on the top of the file.

Maybe it whould be a considerable option to switch to this fork:
https://github.com/cpplint/cpplint
It is much freshier and understands C++ better.
When I run the forked version of cpplint locally, this issue is gone (and also many others caused by outdated cpplint).

@cordis-dev
Copy link
Contributor

@Jhuighuy thanks for reporting. CodeFactor now uses cpplint/cpplint fork and your repo was re-inspected. Let me know if you find any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants