Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'access' false positive #68

Closed
marzojr opened this issue Apr 28, 2024 · 2 comments
Closed

'access' false positive #68

marzojr opened this issue Apr 28, 2024 · 2 comments

Comments

@marzojr
Copy link

marzojr commented Apr 28, 2024

CodeFactor is incorrectly diagnosing code as using access POSIX function when it is actually not:

Use of access() (CWE-362, CWE-367)             lines of code = 1
			if (flag.access() == FlagData::GETFLAG)

source

In this line of code, member function access of the class is being used, but CodeFactor is incorrectly misidentifying this as being POSIX syscall access.

The expectation would be to not get a warning in this case, as this is a clear false-positive and a waste of triage time.

@marzojr
Copy link
Author

marzojr commented Apr 28, 2024

For what is worth, I just noticed that it even flags the declaration of a function called access as being in violation of those CVEs -- see this.

@cordis-dev
Copy link
Contributor

@marzojr thanks for reporting. We've now disabled access() security rule until there's a fix for false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants