Skip to content

Files

Latest commit

 

History

History
34 lines (24 loc) · 681 Bytes

Generic.CodeAnalysis.JumbledIncrementer.md

File metadata and controls

34 lines (24 loc) · 681 Bytes

Pattern: Jumbled loop incrementer

Issue: -

Description

To avoid confusion, incrementers in nested loops should use different variable names.

Example

Example of incorrect code:

// $i is used in both loops
for ($i = 0; $i < 10; $i++) {
    for ($j = 0; $j < 10; $i++) {
		do_something($i, $j);
    }
}

Example of correct code:

for ($i = 0; $i < 10; $i++) {
    for ($j = 0; $j < 10; $j++) {
		do_something($i, $j);
    }
}

Further Reading