Pattern: Use of non-standard expr extension
Issue: -
You are using a expr with length, match, index, or substr. These forms did not make it into POSIX, and fail on platforms like MacOS and FreeBSD. Consider replacing them with portable equivalents:
can be trivially replaced with ${#var}
can be trivially replaced with the POSIX form expr str : regex
if you only need a numerical index as part of trying to extract a piece of the string, consider replacing it with parameter expansion:
str="mykey=myvalue"
key="${str%%=*}" # Remove everything after first =, no index required
value="${str#*=}" # Remove everything before first =, no index required
otherwise, you can find the index of the first = using parameter expansion and string length:
str="mykey=myvalue"
x=${str%%=*} # Assign x="mystr"
index=$((${#x}+1)) # Add 1 to length of x
Extract a substring via character index is generally fragile. For example, in this example, any minor changes to the format, including just the version increasing from 8.9 to 8.10, will cause the following snippet to fail:
str="VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Feb 15 2021 12:29:39)"
version=$(expr substr "$str" 19 3)
Instead, consider a different approach:
x="${str%% (*}" # Delete ` (` and everything after, giving "VIM - Vi IMproved 8.2"
version="${x##* }" # Delete everything before last space, giving "8.2"
# Get the fifth word separated by spaces
IFS=" " read -r _ _ _ _ version _ << EOF
$str
EOF
If you still want to use character index, this is trivially done in Bash/Ksh with ${var:offset:length} (0-based).
In POSIX, you can generally use cut, though be careful if the value can contain multiple lines.
Example of incorrect code:
# Find length of string
length=$(expr length "$var")
# Match string against regex
expr match "$input" "[0-9]*"
# Find character index in string
pos=$(expr index "$input" ":")
# Get substring by index
col2=$(expr substr "foo bar baz" 8 5)Example of correct code:
# Find length of string
length=$(expr length "$var")
# Match string against regex
expr match "$input" "[0-9]*"
# Find character index in string
pos=$(expr index "$input" ":")
# Get substring by index
col2=$(expr substr "foo bar baz" 8 5)