chore: organize ts files and tooling #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
github-actions
bot
added
documentation
0xRAG
force-pushed
the
chore/organize-ts
branch
3 times, most recently
from
023bba4 to
59e890f
Compare
0xRAG
force-pushed
the
chore/organize-ts
branch
from
59e890f to
1d2adf4
Compare
0xRAG
commented
Feb 25, 2025
| @@ -15,7 +15,8 @@ jobs: | |||
| with: | |||
| node-version: "18" | |||
| registry-url: "https://registry.npmjs.org" | |||
| - run: npm ci | |||
There was a problem hiding this comment.
npm ci is ran in the following step
0xRAG
commented
Feb 25, 2025
| # Install dependencies in parent directory first | ||
| - run: npm install | ||
| # formatting/lint in working directory | ||
| cache-dependency-path: ./typescript |
There was a problem hiding this comment.
CarsonRoscoe
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Code wise, happy with the refactor. Makes sense.
Readme update wise, your changes are clear and make sense.
Functionality wise, can confirm:
- Root does nothing, no commands work from root
- From new root (/typescript), every core turbo command (build, format/format:check, lint/lint:fix) is still being ran on all 8 node packages
- Build still injects
@coinbase/agentkitinto the chatbot examples properly for good devx
Overall, LGTM
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Moves all TypeScript ecosystem files & tooling into the root
typescript/folder for better organization & separation between TypeScript and Python, and in preparation for the incoming addition of ecosystem-specific changelog management tooling.In general, we are now treating the
coinbase/agentkitrepo as a repo that houses two distinct monorepos: one for TypeScript and one for Python.All relevant readmes and contributing files have been updated, along with GitHub Actions.