-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rattler-build #184
base: main
Are you sure you want to change the base?
Use rattler-build #184
Conversation
…onda-forge-pinning 2025.02.09.08.37.15
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13226460870. Examine the logs at this URL for more detail. |
…onda-forge-pinning 2025.02.09.14.38.22
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Welp, getting a linux build isn't too shabby for a first cut. I'll dig through the logs a bit... i wonder if |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
For recipe/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13228689707. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Welp, this is basically building now: not sure what further tricks might be able to be pulled to claw back some disk during the |
…onda-forge-pinning 2025.02.09.14.38.22
You can add azure:
free_disk_space: true to |
I promise not to poke it any more until it builds 🤞 actually, unlikely to do any further conda-forge things today, so if there is anything glaring, please do jump in! |
Love to see that. |
Yeah, looks like it worked, and had the desired net effect: This is likely reviewable as-is, though would feel better if i had also turned on artifact uploading, and someone could shake it down on some non- I guess the next step (likely not on this PR, but could be, I guess) would be to see if we can split the JRE bits into their own package. Looking again at, for example, debian's jre and jdk, it's not immediately obvious how one might make that call (e.g. everything in |
One thing in perusing various other packagings: arch adds some more build flags: if check_option "lto" "y"; then
jvm_features="zgc,shenandoahgc,link-time-opt"
else
jvm_features="zgc,shenandoahgc"
fi
bash configure \
--with-jvm-features="${jvm_features}" \ Browsing through failure modes related to this, it sounds like the biggest threat is it being slow and using more memory, but otherwise, if we're doing source builds... |
I don't mind the builds here taking longer as long as it provides a net benefit for users
Let's please move that part of the conversation to #152 - if you can lay out the concerns and how we might address them, that would be useful! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)References:
recipe.yaml
? #183Notes:
outputs
to see if there are gremlins, might need an explicitscript: file: build