Java 8 - Add powershell [de]activate scripts #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinerm
requested review from
CJ-Wright,
johanneskoester,
mingwandroid,
sodre and
xhochy
as code owners
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
Java 8 is a bit "in between". I haven't backported any fixes, migrations or new patch releases here, but (in contrast to java 9/10) I would accept a PR that has green CI. |
hinerm
force-pushed
the
java8
branch
2 times, most recently
from
593b83e to
d3f8c41
Compare
This allows JAVA_HOME to be [un]set as appropriate when [de]activating a conda environment with OpenJDK.
The deactivate script should now return JAVA_HOME to its previous state (including being unset) if and only if the activate script was run first.
…nda-forge-pinning 2025.03.04.20.18.55
|
@h-vetinari whoops, I guess the path is different in Java 8 Windows (no It should be all good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Java 8 backport of #186