Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process thinking blocks for Anthropic with Bedrock provider #4453

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

ferenci84
Copy link
Contributor

Description

This is a continuation of PR #4426 with implementation for Bedrock.

Replacement of PR #4444

Checklist

  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

(No docs have been updated because I believe more has to be done before this feature becomes public)

Testing instructions

It can be tested the same way as the PR 4426 with the following config:

{
      "title": "AWS - Claude 3.7 Sonnet (reasoning)",
      "provider": "bedrock",
      "model": "arn:aws:bedrock:us-east-1:874087778966:inference-profile/us.anthropic.claude-3-7-sonnet-20250219-v1:0",
      "region": "us-east-1",
      "profile": "default",
      "completionOptions": {
        "temperature": 1,
        "topP": 0.999,
        "maxTokens": 8192,
        "reasoning": true,
        "reasoningBudgetTokens": 1024,
      }
    }

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 7949f9a
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67d0a710d5d6b30008c3dc68

@ferenci84
Copy link
Contributor Author

@chezsmithy I created an issue for tool support: #4470, since you were working on it with bedrock, would you mind to check it?

@ferenci84
Copy link
Contributor Author

@sestinj Can you look into this? Until we don't have a shared implementation, this PR contains solution for extended thinking for both the Anthropic and Bedrock provider, and it's now working well with tools.

Copy link
Contributor

@chezsmithy chezsmithy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferenci84 and @sestinj: I've reviewed this locally and tested it against Claude 3.7 with thinking enabled on AWS Bedrock and it is functioning as expected. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants