Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor system message composition for better code proximity & allow user to enforce empty system message as required by Deepseek R1 series #4506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ferenci84
Copy link
Contributor

@ferenci84 ferenci84 commented Mar 6, 2025

Description

  1. Moved systemMessage composition to a single place - makes it easy to make changes discussed in issue Proposed configuration option for better control over hard-coded system messages #3786
  2. When user defined systemMessage is an explicit empty string, no system message will be created - this resolves Proposed configuration option for better control over hard-coded system messages #3786 (comment)

Note: #4507 is built on top of this one, that contains a more complete, yet experimental solution for the issue #3786

Checklist

  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Testing instructions

If you set empty systemMessage in the model config or in the top-level config, no systemMessage should be used (model config takes precedence even if it's an empty string)

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 11f3351
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67c9350b73741d000836fdcd
😎 Deploy Preview https://deploy-preview-4506--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ferenci84
Copy link
Contributor Author

Other PR submitted on top of this one: #4507

@ferenci84 ferenci84 changed the title System message composition Refactor system message composition Mar 12, 2025
@ferenci84 ferenci84 changed the title Refactor system message composition Refactor system message composition for better code proximity & allow user to enforce empty system message Mar 12, 2025
@ferenci84 ferenci84 changed the title Refactor system message composition for better code proximity & allow user to enforce empty system message Refactor system message composition for better code proximity & allow user to enforce empty system message as required by Deepseek R1 series Mar 12, 2025
@LLukas22
Copy link
Contributor

Would be very nice to have this as an option 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposed configuration option for better control over hard-coded system messages
2 participants