Fixed unwantted selecting behavior for send-to-chat

[Jazzcort]

Description

The original behavior selects the entire first line even though it's only partially selected in the editor. This fix is to get rid of the extra selection from the first line and only send the exact part that gets selected in the editor to the chat section. Granite-Code/granite-code#43

Testing instructions

Partially select the first line and then Cmd-L, check if code snippet appearing in the chat section display the exact part you select in the editor.

[netlify]

✅ Deploy Preview for continuedev canceled.

Name	Link
🔨 Latest commit	67957e2
🔍 Latest deploy log	https://app.netlify.com/sites/continuedev/deploys/67cb3fb0eac2b000088a0098

[owtaylor]

Hmm, this entirely bypasses the code in getRangeInFileWithContents() that is causing the problem:

    // adjust starting position to include indentation
    const start = new vscode.Position(selection.start.line, 0);
    const selectionRange = new vscode.Range(start, selection.end);

But I think that code does have a point - if you select with shift-downarrow, it's easy to get a selection that includes the first line without the whitespace, and the rest of the lines with the whitespace:

In that case, we don't want to send to the model:

multiply(number) {
    this.result *= number;
    return this;
  }

Probably that code needs to be fancier - to check if the text at the beginning of the first line is all whitespace and only then adjust the first line boundary to be the start of the line.

[owtaylor]

This looks good to me now, but I think there are a few changes additional changes that could be done to tighten up the code and make it more readable.

[owtaylor]

This doesn't look necessary - getRangeInFileWithContents() already handles that.

[owtaylor]

There's a little compression we can do here:

const beginningOfSelectionStartLine = selection.start.with(undefined, 0);

[owtaylor]

I think this is just "text" not "context". I also think it would be clearer not to have the rangeBeforeSelectionStart variable and just create the range inline.

[owtaylor]

Writing it this way makes it not clear that we're just adjusting the start position of selectionRange -range also has a with() -

selectionRange = selectionRange.with({ start: beginningOfSelectionStartLine });

would be clearer.

[owtaylor]

Looks good to me now!