edit mode code highlighting fixed to not override cursor selection #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
owtaylor
reviewed
Mar 6, 2025
| @@ -6,7 +6,7 @@ class EditDecorationManager { | |||
| constructor(context: vscode.ExtensionContext) { | |||
| this.decorationType = vscode.window.createTextEditorDecorationType({ | |||
| backgroundColor: new vscode.ThemeColor( | |||
There was a problem hiding this comment.
I'd include a comment here explaining why the new color is a good choice, something like:
// editor.selectionHighlightBackground is documented as always needing to be
// partially transparent. This property is useful when we repurpose it here,
// because it means it won't entirely obscure the selection
When switching to the edit mode and we make a selection of code, it needs to appear above the highlighting not be obscured by it. In this fix, instead of using an opaque background colour for the highlighting decoration, we use a highlighting with opacity so that the selected code is visible below it
panyamkeerthana
force-pushed
the
panyamkeerthana/edit-highlight-fix
branch
from
22a6454 to
dc33d50
Compare
|
Looks good to me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When switching to the edit mode and we make a selection of code, it needs to appear above the highlighting not be obscured by it. In this fix, instead of using an opaque background colour for the highlighting decoration, we use a highlighting with opacity so that the selected code is visible below it
Screenshots
Link: Granite-Code/granite-code#47