Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update library #15

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

update library #15

wants to merge 9 commits into from

Conversation

niphlod
Copy link

@niphlod niphlod commented Jan 20, 2025

hi @potatoqualitee , this is a very first try of what I think needs to be done in order for us to update the library

niphlod and others added 4 commits January 20, 2025 22:52
thank you @ashdar 🙏  Sorry it took so long! now there'd be a conflict so i added it myself
@niphlod
Copy link
Author

niphlod commented Feb 10, 2025

ok @potatoqualitee , so now that the library is build, is it time to push an updated version ?

$null = Install-Package @parms


# README cl: this dll is already there, as we're building dbatools csproj whose dependencies are already included !?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, I don't know. Everything that I've done is generally a requirement to get one thing or another working. Libraries are not my strong suit. I suppose if things don't work we can switch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's some issue with runtimes vs regular

@niphlod
Copy link
Author

niphlod commented Mar 6, 2025

Hi @potatoqualitee , just pushed a tidbit little class, DbaRenewableToken, that could start being useful for looking at solving the issue dataplat/dbatools#9612 . Looked also on old notes here dataplat/dbatools#5445 . Seems to work on my own lapdog, with a few modifications needed to "dbatools\bin\typealiases.ps1" to add the new type and a little more magic to Connect-DbaInstance.
If it works, we can see if we can implement better also the glue needed for New-DbaAzAccessToken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants