Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoRollout CRD are not up-to-date #397

Closed
dacofr opened this issue Oct 14, 2024 · 0 comments · Fixed by #398
Closed

ArgoRollout CRD are not up-to-date #397

dacofr opened this issue Oct 14, 2024 · 0 comments · Fixed by #398

Comments

@dacofr
Copy link
Contributor

dacofr commented Oct 14, 2024

When trying to validate an AnalysisTemplate spec with kubeconform

  "resources": [
    {
      "filename": "/tmp/rendered.yaml",
      "kind": "AnalysisTemplate",
      "name": "appname-datadog",
      "version": "argoproj.io/v1alpha1",
      "status": "statusInvalid",
      "msg": "problem validating schema. Check JSON formatting: jsonschema: '/spec/metrics/0/provider/datadog' does not validate with file:///home/daco/work/workshop/CRDs-catalog/argoproj.io/analysistemplate_v1alpha1.json#/properties/spec/properties/metrics/items/properties/provider/properties/datadog/required: missing properties: 'query'",
      "validationErrors": [
        {
          "path": "/spec/metrics/0/provider/datadog",
          "msg": "missing properties: 'query'"
        },
        {
          "path": "/spec/metrics/0/provider/datadog",
          "msg": "additionalProperties 'queries' not allowed"
        }
      ]
    }
  ],

Not sure, but I think it's a regression introduced in #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant