Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add azureMonitor type for Log forwarder schema #399

Closed
priyas16 opened this issue Oct 15, 2024 · 5 comments
Closed

Request to add azureMonitor type for Log forwarder schema #399

priyas16 opened this issue Oct 15, 2024 · 5 comments

Comments

@priyas16
Copy link
Contributor

Hi Team,

We were trying to forward our cluster logs into Azure by using the below configuration which is working as expected.

`apiVersion: logging.openshift.io/v1
kind: ClusterLogForwarder
metadata:
name: instance
namespace: openshift-logging
spec:
outputs:

  • name: azure-monitor-audit
    type: azureMonitor
    azureMonitor:
    customerId: <WORKSPACE_ID>
    logType: aro_audit_logs
    secret:
    name: azure-monitor-shared-key`

However when we add it in GitHub, it fails with the below validation check, since the output type for azureMonitor is not part of the schema.

Error:
ClusterLogForwarder instance is invalid: problem validating schema. Check JSON formatting: jsonschema: '/spec/outputs/0/type' does not validate with https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/logging.openshift.io/clusterlogforwarder_v1.json#/properties/spec/properties/outputs/items/properties/type/enum: value must be one of "syslog", "fluentdForward", "elasticsearch", "kafka", "cloudwatch", "loki", "googleCloudLogging", "splunk", "http"

Request you to please add it in output type, so that we can get our validation completed.

Thanks!

@eyarz
Copy link
Member

eyarz commented Oct 15, 2024

my guess is that the schema is out-of-date
you can open a PR with the updated schema and I will merge it :)

@priyas16
Copy link
Contributor Author

Hi eyarz,

Sure, raised the below PR, could you please review and approve. Thanks!

#401

@priyas16
Copy link
Contributor Author

Hi Team,
Could you please approve the above request, since we are still facing the issue. Thanks!

@priyas16
Copy link
Contributor Author

Hi @eyarz,

Thank you so much for approving and merging the PR, the issue is resolved! Hence will close this request.

@priyas16
Copy link
Contributor Author

Hi @eyarz,

Thank you so much for approving and merging the PR, the issue is resolved! Hence will close this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants