Skip to content
This repository was archived by the owner on Jun 6, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: datreeio/datree
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.9.19
Choose a base ref
...
head repository: datreeio/datree
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 3 commits
  • 3 files changed
  • 4 contributors

Commits on Jul 23, 2023

  1. fix: make cel expression policy work (#963)

    Co-authored-by: teselil <tzlil@datree.com>
    TzlilSwimmer123 and teselil authored Jul 23, 2023
    Copy the full SHA
    305e848 View commit details

Commits on Jul 24, 2023

  1. perf(httpClient): compare strings with strings.EqualFold (#962)

    Comparing two strings to the same case with `strings.ToLower` is more
    computational expensive than `strings.EqualFold`.
    
    Sample benchmark:
    
    func BenchmarkToLower(b *testing.B) {
    	for i := 0; i < b.N; i++ {
    		if strings.ToLower("CONTENT-TYPE") != strings.ToLower("content-type") {
    			b.Fail()
    		}
    	}
    }
    
    func BenchmarkEqualFold(b *testing.B) {
    	for i := 0; i < b.N; i++ {
    		if !strings.EqualFold("CONTENT-TYPE", "content-type") {
    			b.Fail()
    		}
    	}
    }
    
    goos: linux
    goarch: amd64
    pkg: github.com/datreeio/datree/pkg/httpClient
    cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics
    BenchmarkToLower-16      	 8183317	       192.1 ns/op	      16 B/op	       1 allocs/op
    BenchmarkEqualFold-16    	82634701	        12.92 ns/op	       0 B/op	       0 allocs/op
    PASS
    ok  	github.com/datreeio/datree/pkg/httpClient	4.181s
    
    Reference: https://staticcheck.dev/docs/checks/#SA6005
    
    Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
    Juneezee authored Jul 24, 2023
    Copy the full SHA
    0b67300 View commit details

Commits on Aug 1, 2023

  1. docs: deprecation notice (#964)

    Eyar Zilberman authored Aug 1, 2023
    Copy the full SHA
    0c3b63e View commit details
Loading