fix(ally): increased weak badge border color contrast #3890
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranzke
added
🐛bug
7 tasks
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/3887-fixally-change-border-color-for-badge-weak |
|
@leape QS URLs:
I assume that a change to the badge should also change the weak tag (mainly as those were interconnected for some declarations in the past). If this is a misunderstanding, please let me know. |
The border color of the tag remains unchanged at emphasis-60. One thing about the badge: Emphasis weak has bg-basic-level-3 as background, the rest is fine! Thanks. |
mfranzke
changed the title
nmerget
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #3887
Types of changes
Further comments