Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue for angular and vue triggered "checked" instead of "value" #3880

Merged
merged 5 commits into from
Mar 4, 2025
Merged

fix: issue for angular and vue triggered "checked" instead of "value" #3880

merged 5 commits into from
Mar 4, 2025

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Feb 28, 2025

Proposed changes

Currently the ngModel informs about checked for radio which makes no sense. It should inform the user with the value

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested a review from mfranzke as a code owner February 28, 2025 13:14
@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Feb 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-angular-vue-radio-update

@nmerget nmerget added the 👩‍👧‍👦community feedback Feedback from community label Feb 28, 2025
@mfranzke
Copy link
Collaborator

mfranzke commented Feb 28, 2025 •
edited
Loading

@nmerget wouldn't this be a BREAKING CHANGE ?

it's a bugfix.

@nmerget nmerget enabled auto-merge (squash) March 4, 2025 07:09
@nmerget nmerget merged commit c0926b1 into main Mar 4, 2025
72 checks passed
@nmerget nmerget deleted the fix-angular-vue-radio-update branch March 4, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke

Assignees

@mfranzke mfranzke

Labels
👩‍👧‍👦community feedback Feedback from community 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke