Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove DeprecationWarning about pandas Dataframes from EvaluationRunResult #8955

Open
julian-risch opened this issue Mar 4, 2025 · 1 comment
Open

remove DeprecationWarning about pandas Dataframes from EvaluationRunResult #8955

julian-risch opened this issue Mar 4, 2025 · 1 comment
Labels
P2 Medium priority, add to the next sprint if no P1 available
Milestone
2.12.0

Comments

@julian-risch
Copy link
Member

julian-risch commented Mar 4, 2025 •
edited
Loading

We made pandas Dataframes optional in EvaluationRunResult in PR #8838 and added a DeprecationWarning before after releasing 2.10. Before After the 2.11 release, we should remove the deprecated to_pandas and comparative_individual_scores_report and score_report
@julian-risch julian-risch added the P1 High priority, add to the next sprint label Mar 4, 2025
@julian-risch julian-risch added this to the 2.11.0 milestone Mar 4, 2025
@anakin87
Copy link
Member

anakin87 commented Mar 4, 2025 •
edited
Loading

DeprecationWarnings are not present in 2.10.x. See https://github.com/deepset-ai/haystack/blob/v2.10.x/haystack/evaluation/eval_run_result.py

To be consistent with our deprecation policy, we should:

  • do deprecations in 2.11.0 (and change the deprecation warning to reflect the correct version)
  • remove deprecated methods in 2.12.0.

We can sync on this if needed.

@julian-risch julian-risch modified the milestones: 2.11.0, 2.12.0 Mar 4, 2025
@julian-risch julian-risch added P2 Medium priority, add to the next sprint if no P1 available and removed P1 High priority, add to the next sprint labels Mar 4, 2025
@julian-risch julian-risch mentioned this issue Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Medium priority, add to the next sprint if no P1 available
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
2 participants
@julian-risch @anakin87