Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port bake object syntax #317

Merged
merged 13 commits into from
Mar 5, 2025
Merged

Conversation

goller
Copy link
Collaborator

@goller goller commented Mar 1, 2025

output, cache-from, cache-to, secret, and ssh can be csv strings or object syntax.

The intent is to be fully backwards compatible.

output, cache-from, cache-to, secret, and ssh can be csv strings or object syntax.

The intent is to be fully backwards compatible.

Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
From buildx commit:

> Small fix for the condition of linking to itself.
> target.Name is usually empty as used by the matrix feature.
> This still errored before as well because the infinite loop was detected,
> but this error condition was ineffective.

Signed-off-by: Chris Goller <goller@gmail.com>
From upstream commit:

> Previously, we would fail while trying to use the global "target"
> field when using a matrix.
>
> The contents of the matrix really don't matter for this.

Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
This parser supports many types for a parsed field.
Used to support string slice and object slice.

Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
@goller goller requested a review from jacobwgillespie March 1, 2025 21:28
Copy link
Member

@jacobwgillespie jacobwgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jacobwgillespie jacobwgillespie merged commit b6118b1 into main Mar 5, 2025
6 checks passed
@jacobwgillespie jacobwgillespie deleted the feat/bake-csv-and-object-support branch March 5, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants