-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port bake object syntax #317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
output, cache-from, cache-to, secret, and ssh can be csv strings or object syntax. The intent is to be fully backwards compatible. Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
From buildx commit: > Small fix for the condition of linking to itself. > target.Name is usually empty as used by the matrix feature. > This still errored before as well because the infinite loop was detected, > but this error condition was ineffective. Signed-off-by: Chris Goller <goller@gmail.com>
From upstream commit: > Previously, we would fail while trying to use the global "target" > field when using a matrix. > > The contents of the matrix really don't matter for this. Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
This parser supports many types for a parsed field. Used to support string slice and object slice. Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
jacobwgillespie
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output, cache-from, cache-to, secret, and ssh can be csv strings or object syntax.
The intent is to be fully backwards compatible.