Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: checkIsLatestVersion doesnt work as expected #40

Open
di-sukharev opened this issue Mar 21, 2023 · 4 comments
Open

bug: checkIsLatestVersion doesnt work as expected #40

di-sukharev opened this issue Mar 21, 2023 · 4 comments

Comments

@di-sukharev
Copy link
Owner

the function checkIsLatestVersion always returns that version is not latest..

@di-sukharev
Copy link
Owner Author

anybody could fix that?

@matt-degraffenreid
Copy link
Contributor

hey @di-sukharev I'm not able to reproduce this bug on my end.

Steps I took to reproduce:

  1. Clone the opencommit repo.
  2. Build the project and run npm link.
  3. Open a dummy project and run npm link opencommit.
  4. I uncommented the needed lines in cli.ts
  5. when running with 1.1.22 as the version number in the package.json no message pops up as expected
  6. when I change the version number in the package.json to something <1.1.22 I get the message as expected.

Let me know if I'm not following correctly.

@di-sukharev
Copy link
Owner Author

thanks bro,

it works when tested locally, but it shows the message all the time in prod

here is how it goes for me — when i install latest npm i -g opencommit@latest and run oc --version i see not the latest version, but the version before latest, that's why message is displayed all the time. I believe it's due to some npm latest tag management.

image

@github-actions
Copy link

github-actions bot commented May 3, 2023

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants