Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for commit prefix #160

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
+5,834 −3,809
Open

Allow for commit prefix #160

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
83a919b
feat(api.ts): add support for prefix configuration to be added to the…
amitayk May 4, 2023
098db00
refactor(api.ts): improve readability by adding a space between prefi…
amitayk May 4, 2023
b15a100
fix(api.ts): fix generatePrefix function to return undefined when con…
amitayk May 4, 2023
abb488e
feat(api.ts): add support for generating commit message prefix from r…
amitayk May 4, 2023
2577ec1
Update src/api.ts
amitayk May 7, 2023
4f6e95a
refactor(api.ts): replace child_process.execSync with execaCommandSyn…
amitayk May 7, 2023
148773e
chore(package.json): remove unused "child_process" dependency to decl…
amitayk May 7, 2023
52122de
Merge with master
amitayk May 23, 2023
dae0408
Allow For Prefix: fix(config.ts): fix typo in OCO_PREFIX environment …
amitayk May 27, 2023
e0d1850
Allow For Prefix: refactor(api.ts): improve prefix validation by usin…
amitayk May 27, 2023
5021017
build
amitayk May 27, 2023
af6f99b
Allow For Prefix: refactor(api.ts): extract message prefixing logic t…
amitayk May 27, 2023
59bc005
build
amitayk May 27, 2023
a82f8d0
Merge branch 'dev' of https://github.com/di-sukharev/opencommit into …
amitayk May 27, 2023
02d0171
build
amitayk May 28, 2023
140761c
Update src/commands/config.ts
di-sukharev Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(api.ts): improve readability by adding a space between prefi… 
…x and message content

fix(config.ts): fix config validation for prefix to allow non-empty values
  • Loading branch information
@amitayk
amitayk committed May 4, 2023
commit 098db008f297d07521008bd60d9593d69406cc65
2 changes: 1 addition & 1 deletion src/api.ts
View file
Original file line number Diff line number Diff line change
@@ -61,7 +61,7 @@ class OpenAi {

const prefix = generatePrefix();

const finalMessage = (prefix || '') + (message?.content || '');
const finalMessage = (prefix ? prefix + ' ' : '') + (message?.content || '')

return finalMessage;
} catch (error: unknown) {
2 changes: 1 addition & 1 deletion src/commands/config.ts
View file
Original file line number Diff line number Diff line change
@@ -115,7 +115,7 @@ export const configValidators = {
[CONFIG_KEYS.prefix](value: any) {
validateConfig(
CONFIG_KEYS.prefix,
value,
true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true is not validating anything here :) we should validate the config input with a function or expression which return Boolean

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@di-sukharev Do you have an idea what can we validate?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you somehow need to confirm that the value is the exact format you expect, if your format is ^(*) and not /^(*)/ — make sure you don't have /s in the value, you may also do multiple validations like !a && b && !c

'Cannot be empty'
);
return value;