Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply mergability check should not fail if the "digger/apply" status check is the only thing blocking #1180

Open
motatoes opened this issue Feb 19, 2024 · 2 comments

Comments

@motatoes
Copy link
Contributor

motatoes commented Feb 19, 2024

In #1150 we have implemented an aggregate status check (#959) for digger digger/plan and digger/apply. Although those are set correctly there is an additional mergability check which causes digger apply step to fail IF the PR is not mergable.

This has introduced chicken-egg situation where you want digger/apply check to succeed for PR to be mergable but digger/apply needs to complete

We should do an additional check on mergability where if PR state is "blocked" and the only check blocking it is "digger/apply" then to still proceed with the apply

Screenshot 2024-02-19 at 12 10 54
@ZIJ ZIJ changed the title digger apply mergability check should not fail if the "digger/apply" status check is the only thing blocking Apply mergability check should not fail if the "digger/apply" status check is the only thing blocking Feb 22, 2024
@liamwitt
Copy link

liamwitt commented Jul 3, 2024

What's the current workaround for this in terms of ensuring that digger apply has run before a PR is merged? It seems as though it is feasible for changes to not be applied before merge with human error.

@motatoes
Copy link
Contributor Author

motatoes commented Jul 3, 2024

No workaround yet unfortunately until we ship a check to ignore that status check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants