Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom steps should not fail the workflow #1204

Open
ZIJ opened this issue Feb 23, 2024 · 1 comment
Open

Custom steps should not fail the workflow #1204

ZIJ opened this issue Feb 23, 2024 · 1 comment

Comments

@ZIJ
Copy link
Contributor

ZIJ commented Feb 23, 2024

Wouldn't be more practical if the checkov tests results including both Failed and Passed are commented in PR, as it would be easier to read what has to be changed rather scrolling in the runner logs and having a failed workflow?

  • workflow job to succeed
  • custom step (checkov) failure reported as a comment instead

I think if it doesn't pass the checks then having the workflow job to fail is a fine, but it should say why it failed, as you suggested as a custom step (checkov) failure reported as a comment.

Reported by the user A.D in support

@motatoes
Copy link
Contributor

I think if a custom step returns non zero status it should still be considered as a failed workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants