You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interesting, looks like that triggers a pull_request_review_comment event :D . We need to handle that in orchestrator and handle it as a comment event 👍 Adding as good first issue to see if someone wants to grab it
An important difference between issue_comment and pull_request_review_comment is that GITHUB_REF is the default branch for the former, but refs/pull/PULL_REQUEST_NUMBER/merge for the latter (see docs). This makes the review comment more integrated into the pull request context (e.g. not having to do this).
A GitHub feature request has been raised for making issue_comment in PRs (or a new PR comment event type) use the PR ref, but until then the pull_request_review_comment is the best option.
Thanks @ahuseby ! So we will need to that event and handle it on digger side. I think issue number will still remain so that action.yml logic would still work
Thanks @ahuseby ! So we will need to that event and handle it on digger side. I think issue number will still remain so that action.yml logic would still work
That's right 😄 I'll try and take a look at contributing a change for this
Currently, this comment does not cause Digger to react, meaning I have to make another comment after I approve.
The text was updated successfully, but these errors were encountered: