We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In most of our tests we listen for:
pull_request: types: [opened, reopened]
It seems to not trigger for external cotributors. We should replace it with:
pull_request:
because that seems to work better
The text was updated successfully, but these errors were encountered:
Will likely want to have something like:
if: github.event.pull_request.head.repo.full_name == github.repository
or
if: github.repository_owner == 'diggerhq'
in the job definition header as well to avoid forks running tasks in the source repo etc..that could expose things that might not want to be exposed.
Sorry, something went wrong.
Yeah so true, that will be needed. I think the only one that exposes secrets is the e2e tests, rest don't contain sensitive data :)
No branches or pull requests
In most of our tests we listen for:
It seems to not trigger for external cotributors. We should replace it with:
because that seems to work better
The text was updated successfully, but these errors were encountered: