Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tests trigger for external contributors #1293

Open
motatoes opened this issue Mar 20, 2024 · 2 comments
Open

make tests trigger for external contributors #1293

motatoes opened this issue Mar 20, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@motatoes
Copy link
Contributor

In most of our tests we listen for:

  pull_request:
    types: [opened, reopened]

It seems to not trigger for external cotributors. We should replace it with:

  pull_request:

because that seems to work better

@motatoes motatoes added the good first issue Good for newcomers label Mar 20, 2024
@JoshuaJackson-jobvite
Copy link
Contributor

JoshuaJackson-jobvite commented Mar 21, 2024

Will likely want to have something like:

    if: github.event.pull_request.head.repo.full_name == github.repository

or

    if: github.repository_owner == 'diggerhq'

in the job definition header as well to avoid forks running tasks in the source repo etc..that could expose things that might not want to be exposed.

@motatoes
Copy link
Contributor Author

Yeah so true, that will be needed. I think the only one that exposes secrets is the e2e tests, rest don't contain sensitive data :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants