Implement unique project name validation in Digger configuration #1767
+72
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motatoes
reviewed
Nov 4, 2024
| } | ||
|
|
||
| // check for project name duplicates | ||
| // Check for project name duplicates | ||
| projectNames := make(map[string]bool) |
There was a problem hiding this comment.
Hello this duplication check is already being performed here, unfortunately your PR adds duplicate logic and that change has already been merged into the main branch
|
Hi there, thanks for contributing! unfortunately this issue is stale and has already been implemented in a previous PR, I unfortunately wont be able to accept this as a contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1309
This PR implements a crucial feature to ensure that project names in the Digger configuration (digger.yml) are unique. This is an important prerequisite for proper functionality, as Digger relies on project names to organize various resources, including state files.
Key Changes to Digger Configuration
1. Updated ValidateDiggerConfigYaml function in
libs/digger_config/yaml.go:2. Modified ConvertDiggerYamlToConfig function in
libs/digger_config/converters.go:3. Added a new test case
TestDiggerConfigDuplicateProjectNamesinlibs/digger_config/digger_config_test.go:4. Updated Documentation in
docs/ce/reference/digger.yml.mdx:namefield must be unique across all projects.Please review these changes and let me know if any further modifications or clarifications are needed.